-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages #6780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(type-utils): fixed TypeOrValueSpecifier not accounting for scoped DT packages #6780
Conversation
Thanks for the PR, @marekdedic! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
(ast.body[ast.body.length - 1] as TSESTree.TSTypeAliasDeclaration) | ||
.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think this fixes a minor issue that is probably present in more tests - I have taken this directly out of some other tests in this repo
…ually wasn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, thanks for the fast follow! Just requesting changes on 1-2 cleanups, lmk what you think?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6780 +/- ##
==========================================
+ Coverage 87.36% 87.51% +0.14%
==========================================
Files 373 376 +3
Lines 12800 12940 +140
Branches 3793 3820 +27
==========================================
+ Hits 11183 11324 +141
+ Misses 1232 1231 -1
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Checklist
Overview