-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(website): [playground] allow to choose file extensions #6785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
0a22f1f
to
a77fcf0
Compare
export const fileTypes: ConfigFileType[] = [ | ||
'ts', | ||
'tsx', | ||
'js', | ||
'jsx', | ||
'd.ts', | ||
'cjs', | ||
'mjs', | ||
'cts', | ||
'mts', | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be Object.values(ts.Extension)
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when this variable is initialized playground and typescript is not loaded yet and we can't wait for playground to load because this is needed to define file name that is used by playground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
PR Checklist
Overview
This change replaces
jsx
checkbox with dropdown of supported file extensionsref #5449