test(plugin-typescript): migrate eslint rule tests from parser to plugin #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 48 48
Lines 2469 2469
Branches 381 381
=======================================
Hits 2340 2340
Misses 77 77
Partials 52 52Continue to review full report at Codecov.
|
bradzacher
previously approved these changes
Jan 18, 2019
|
Nice! I have an updated integration test I’ll be submitting later too |
bradzacher
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates regression tests for eslint rules to eslint-plugin and adds additional test cases for #64 #58 #23 #25
eslint regression tests was moved outside of
rulesdirectory toeslint-rulescloses: #64
closes: #58
closes: #23
closes: #25