Skip to content

chore(website): [playground] use languageService for linting code #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 7, 2023
Merged

chore(website): [playground] use languageService for linting code #6806

merged 12 commits into from
Apr 7, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Mar 31, 2023 •
edited
Loading

PR Checklist

Overview

extracted from #6656

  • migrate custom program creation to languageService
  • correct issues with race conditions and double lint
  • use tsvfs in broader scope to create program, store and sync files content
  • create clear boundaries between editor, linter and parser

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Mar 31, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f04f533
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/642d9ae943a5070008995f82
😎 Deploy Preview https://deploy-preview-6806--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2

This comment was marked as resolved.

Sign in to view
@armano2 armano2 marked this pull request as draft March 31, 2023 16:34
@nx-cloud
Copy link

nx-cloud bot commented Mar 31, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f04f533. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@armano2 armano2 changed the title chore(website): [playground] use tsvfs as for linting code chore(website): [playground] use tsvfs for linting code Mar 31, 2023
@bradzacher
Copy link
Member

I wonder if we should make it easier to integrate the vfs into our parser by adding a new API?

@armano2 armano2 marked this pull request as ready for review April 1, 2023 14:32
@armano2
Copy link
Collaborator Author

armano2 commented Apr 1, 2023 •
edited
Loading

I wonder if we should make it easier to integrate the vfs into our parser by adding a new API?

that could work, but in our case we actually have to get ast from parser witch currently is done during parsing

https://github.com/typescript-eslint/typescript-eslint/pull/6806/files#diff-d05a371466c38384729239098e16a3a40108ecf9bff740757faca055e308f6edR27-R28

https://github.com/typescript-eslint/typescript-eslint/pull/6806/files#diff-ce4bea04942123f7add4111ea7ee55b67313bcea7257fb247423c82d0fcd59b3R81-R86

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll admit, this is a lot of TS API -intense stuff that I'm not super familiar with. I'm digging into it now and it all seems good... but I'm in a bit of a rush and can't do a full "read and learn all the things and their context" review 😞. So consider this a medium-level-informed LGTM. Assuming I'm not missing any non-obvious gotchas, the code looks great! Awesome! 🔥

@armano2 armano2 requested a review from JoshuaKGoldberg April 3, 2023 21:54
@armano2 armano2 changed the title chore(website): [playground] use tsvfs for linting code chore(website): [playground] use languageService for linting code Apr 7, 2023
@armano2 armano2 merged commit a35a2bb into v6 Apr 7, 2023
@armano2 armano2 deleted the chore/playground-refactor-code-to-use-tsvfs branch April 7, 2023 09:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armano2 @bradzacher @JoshuaKGoldberg