Skip to content

docs: update pull requests docs to include a how to ask section #6872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2023
Merged

docs: update pull requests docs to include a how to ask section #6872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0a351b
Update Pull_Requests.mdx
sfavello Apr 8, 2023
f35f26b
Update docs/contributing/Pull_Requests.mdx
sfavello Apr 8, 2023
3befe6e
Update docs/contributing/Pull_Requests.mdx
sfavello Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/contributing/Pull_Requests.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,9 @@ You can [resolve conversations](https://docs.github.com/en/pull-requests/collabo
Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed.

Once the feedback is addressed, and the PR is approved, we'll ensure the branch is up to date with `main`, and merge it for you.

### Asking Questions

If you need help and/or have a question, posting a comment in the PR is a great way to do so.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lil grammar nit since the heading is updated)

Suggested change
If you need help and/or have a question, posting a comment in the PR is a great way to do so.
If you need help and/or have a question, posting a comment in the PR is a great way to ask.

There's no need to tag anybody individually.
One of us will drop by and help when we can.