fix(eslint-plugin): [no-unnecessary-condition] allow nullish coalescing for naked type parameter #6910
Conversation
…ng for naked type parameter
|
Thanks for the PR, @dora1998! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6910 +/- ##
=======================================
Coverage 87.36% 87.37%
=======================================
Files 386 386
Lines 13189 13192 +3
Branches 3866 3867 +1
=======================================
+ Hits 11523 11526 +3
Misses 1300 1300
Partials 366 366
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| } | ||
| `, | ||
| ` | ||
| function test<T>(a: T) { |
There was a problem hiding this comment.
[Testing] The cases of T extends 'a' (always truthy) and T extends 'a' | null (still needing ??) seem to work, but aren't explicitly covered for ?? cases. Could you add in a couple more unit tests along those lines please?
There was a problem hiding this comment.
Oh sorry, I added them!
I also added a alwaysNullish case 😄
PR Checklist
Overview
Allow nullish coalescing for a naked type parameter because it might be nullable.