-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: flesh out tips for typed linting and .eslintrc.cjs #6919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: flesh out tips for typed linting and .eslintrc.cjs #6919
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jutanium would love your input on this if you have time 😇
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6919 +/- ##
==========================================
- Coverage 87.37% 87.37% -0.01%
==========================================
Files 386 386
Lines 13195 13192 -3
Branches 3867 3867
==========================================
- Hits 11529 11526 -3
Misses 1300 1300
Partials 366 366
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 😀
3de2d52
PR Checklist
Overview
Doesn't provide an explicit "here's the right way to do this!" because I don't think there is one 🥲. At least not unless ESLint configs eventually could be written in TypeScript!
Instead, adds an explicit caution note and bolsters the FAQ entry to explicitly handle the idea of a root-level
.cjs
/.js
file and typed linting.