-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: bump minimum TS to 4.3.5 #6923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6923 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 376 376
Lines 12934 12934
Branches 3820 3820
=======================================
Hits 11318 11318
Misses 1231 1231
Partials 385 385
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -84,6 +84,7 @@ _ts4.2 | |||
# the downlevel-dts output folders | |||
_ts3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of _ts3.4
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep it in gitignore until we merge it, as it will prevent us from accidently pushing those files while switching between v6 and main
Overview
We've taken a minute here to finish our v6 so v4.2.4 has now fallen outside the 2 year support window for versions.
This bumps the minimum to v4.3.5.
This also makes our lives easier for #6723