Skip to content

fix(eslint-plugin): [prefer-regexp-exec] skip malformed regexes #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix(eslint-plugin): [prefer-regexp-exec] skip malformed regexes #6935

merged 1 commit into from
Apr 19, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

PR Checklist

Overview

The fix try-catches any string literals denoting malformed regular expressions passed to the function constructor RegExp. If a runtime error is thrown, the visited node is skipped, and no issue is reported.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yassin-kammoun-sonarsource!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 19, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 63192f3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/643fd2fd1a8a8000082ba88d
😎 Deploy Preview https://deploy-preview-6935--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented Apr 19, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 63192f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #6935 (63192f3) into main (4f3750f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6935   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         386      386           
  Lines       13192    13194    +2     
  Branches     3867     3867           
=======================================
+ Hits        11526    11528    +2     
  Misses       1300     1300           
  Partials      366      366
Flag Coverage Δ
unittest 87.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 100.00% <100.00%> (ø)

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 perfect, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 05ed60e into typescript-eslint:main Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [prefer-regexp-exec] Runtime errors on malformed regular expressions
2 participants
@yassin-kammoun-sonarsource @JoshuaKGoldberg