Skip to content

fix: correct handling of additionalProperties in object schemas #6939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: correct handling of additionalProperties in object schemas #6939

merged 1 commit into from
Apr 21, 2023

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Apr 20, 2023 •
edited
Loading

PR Checklist

Overview

@domdomegg's #6894 made me realise I'd incorrectly handled this case in the schema gen.
When it's missing/undefined it's the same as being true - but I treated it as false

@bradzacher @domdomegg
fix: correct handling of additionalProperties in object schemas
223624d 
Co-authored-by: Adam Jones <domdomegg+git@gmail.com>
@bradzacher bradzacher added the bug Something isn't working label Apr 20, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 223624d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64412c047da6e100086cd0a6
😎 Deploy Preview https://deploy-preview-6939--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher bradzacher mentioned this pull request Apr 20, 2023
Closed
3 tasks
@nx-cloud
Copy link

nx-cloud bot commented Apr 20, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 223624d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #6939 (223624d) into v6 (acc1a43) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #6939      +/-   ##
==========================================
- Coverage   87.51%   87.50%   -0.01%     
==========================================
  Files         376      376              
  Lines       12944    12936       -8     
  Branches     3821     3820       -1     
==========================================
- Hits        11328    11320       -8     
  Misses       1231     1231              
  Partials      385      385
Flag Coverage Δ
unittest 87.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.14% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts 96.96% <ø> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 97.47% <ø> (ø)
...-plugin/src/rules/no-unnecessary-type-assertion.ts 94.59% <ø> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts 87.50% <ø> (ø)
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts 90.38% <ø> (ø)
packages/eslint-plugin/src/rules/typedef.ts 96.00% <ø> (ø)

... and 1 file with indirect coverage changes

armano2
armano2 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@bradzacher bradzacher merged commit 489c7a5 into v6 Apr 21, 2023
@bradzacher bradzacher deleted the v6-fix-additional-properties branch April 21, 2023 02:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@domdomegg domdomegg domdomegg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradzacher @armano2 @domdomegg