Skip to content

docs: update PR title subject example #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2023

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented May 22, 2023

PR Checklist

Overview

Preview: https://deploy-preview-7051--typescript-eslint.netlify.app/contributing/pull-requests#raising-a-pr

Got tripped when I named my previous PR with a capitalized subject

image

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @DimitarNestorov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6aa600b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/646b9ef6b71721000899e4de
😎 Deploy Preview https://deploy-preview-7051--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nx-cloud
Copy link

nx-cloud bot commented May 22, 2023

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I'm sad to have inconvenienced you with a docs typo... but am also very glad to hear you're reading these docs 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit a626520 into typescript-eslint:main May 28, 2023
@DimitarNestorov
Copy link
Contributor Author

No worries! My pleasure!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants