Skip to content

docs: correct explicit-module-boundary-types correct case #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

WithakErik
Copy link
Contributor

Updates "Correct" version to match "Incorrect" version of empty function that expects nothing and returns a string (The "Correct" version was expecting a string and returning a concatenated string)

PR Checklist

Overview

Updates "Correct" version to match "Incorrect" version of empty function that expects nothing and returns a string
(The "Correct" version was expecting a string and returning a concatenated string)
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @WithakErik!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d999ede
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64741617020fdd0008e3de89
😎 Deploy Preview https://deploy-preview-7073--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, nice catch - thanks for this!

@JoshuaKGoldberg JoshuaKGoldberg changed the title Update explicit-module-boundary-types.md docs: correct explicit-module-boundary-types correct case May 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit a9cf44b into typescript-eslint:main May 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants