Skip to content

chore: bump to latest lerna and apply custom release entry markdown #7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

JamesHenry
Copy link
Member

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JamesHenry JamesHenry requested a review from bradzacher June 25, 2023 10:02
@netlify
Copy link

netlify bot commented Jun 25, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit add69b0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64982377da50a000089c8db4
😎 Deploy Preview https://deploy-preview-7139--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -1,6 +1,5 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"npmScope": "typescript-eslint",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deprecated and no longer really used in nx, it will derive it from your existing root package

@@ -1,5 +1,11 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this a while ago, always nice to get IDE autocomplete etc

bradzacher
bradzacher previously approved these changes Jun 25, 2023
@bradzacher
Copy link
Member

Thanks for cracking onto this so fast

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@JamesHenry JamesHenry merged commit 5d175e7 into main Jun 25, 2023
@JamesHenry JamesHenry deleted the changelog-entry-markdown branch June 25, 2023 15:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants