Skip to content

docs(eslint-plugin): mention member-delimiter-style in semi #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2019
Merged

docs(eslint-plugin): mention member-delimiter-style in semi #715

merged 2 commits into from
Jul 17, 2019

Conversation

lucaswerkmeister
Copy link
Contributor

Both are related to semicolons, so let’s help looking for member-delimiter-style by linking it here.

Follow-up for #714, where I misunderstood what the semi rule is for.

@lucaswerkmeister
docs(eslint-plugin): mention member-delimiter-style in semi
9ca8772 
Both are related to semicolons, so let’s help looking for
member-delimiter-style by linking it here.
@lucaswerkmeister lucaswerkmeister mentioned this pull request Jul 17, 2019
Closed
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jul 17, 2019
bradzacher
bradzacher requested changes Jul 17, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, please update the wording and then we can merge this

@lucaswerkmeister @bradzacher
Update packages/eslint-plugin/docs/rules/semi.md
c8cb077 
Co-Authored-By: Brad Zacher <brad.zacher@gmail.com>
@bradzacher bradzacher merged commit 66f9741 into typescript-eslint:master Jul 17, 2019
@lucaswerkmeister lucaswerkmeister deleted the patch-1 branch July 17, 2019 23:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaswerkmeister @bradzacher