feat(typescript-estree): always return parserServices #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9205ac to
89c81a5
Compare
BREAKING: previously plugins expected that `parserServices` would be `undefined` if full type information wasn't available.
89c81a5 to
01de581
Compare
|
@bradzacher are you planning to resolve conflicts or do you want me to pick it up? |
|
I was planning on getting back to it eventually, but it's been at a lower priority, because 3.0.0 was so far out 😅. If you get the gist of what I was intending, then feel free to pick this up and get it ready for One important note: |
BREAKING: previously plugins expected that `parserServices` would be `undefined` if full type information wasn't available.
Conflicts: packages/eslint-plugin-tslint/src/rules/config.ts packages/eslint-plugin/tools/validate-docs/validate-table-rules.ts packages/experimental-utils/src/eslint-utils/getParserServices.ts packages/typescript-estree/src/parser-options.ts packages/typescript-estree/src/parser.ts packages/typescript-estree/src/tsconfig-parser.ts packages/typescript-estree/tests/lib/convert.ts packages/typescript-estree/tests/lib/parse.ts
armano2
reviewed
Jan 14, 2020
bradzacher
commented
Jan 14, 2020
bradzacher
commented
Jan 14, 2020
bradzacher
commented
Jan 14, 2020
bradzacher
commented
Jan 15, 2020
Conflicts: packages/eslint-plugin/README.md packages/eslint-plugin/tests/docs.test.ts
bradzacher
commented
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## v3 #716 +/- ##
==========================================
- Coverage 93.87% 93.78% -0.09%
==========================================
Files 172 172
Lines 7805 7809 +4
Branches 2240 2243 +3
==========================================
- Hits 7327 7324 -3
- Misses 221 227 +6
- Partials 257 258 +1
|
# Conflicts: # packages/eslint-plugin/README.md
bradzacher
added a commit
that referenced
this pull request
May 11, 2020
bradzacher
added a commit
that referenced
this pull request
May 14, 2020
bradzacher
added a commit
that referenced
this pull request
May 17, 2020
bradzacher
added a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
previously plugins expected that
parserServiceswould beundefinedif full type information wasn't available.Splitting these changes out of #688 to focus that PR.
The motivation behind this is that this will allow rules to consume diagnostics without needing the user to provide
project, which slows down linting.