Skip to content

chore(website): remove swc: true to fix builds #7167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(website): remove swc: true to fix builds #7167

wants to merge 1 commit into from

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 6, 2023 •
edited
Loading

PR Checklist

Overview

Stops using swc: true in ts-node so that the website will build again.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 718a4ca
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64a73a57bc979c0008c3bb5c
😎 Deploy Preview https://deploy-preview-7167--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from Josh-Cena July 6, 2023 22:04
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 6, 2023
Closed
@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 718a4ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@Josh-Cena
Copy link
Member

I'm quite baffled by this as well. I'll take a look later.

Josh-Cena
Josh-Cena approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the number of weirdities SWC has makes this really hard to debug. Do you think it's better to try adding an .swcrc file? Or we can just get rid of SWC like this—it's only one config file, no big deal.

@rubiesonthesky
Copy link
Contributor

I have other PR for this problem #7182 - let's see if the build succeeds with that change :)

@JoshuaKGoldberg
Copy link
Member Author

Oop, I did this in v6 which is now merged to main. So this PR is redundant.

@JoshuaKGoldberg JoshuaKGoldberg deleted the website-fix-docusaurus-swc branch July 13, 2023 15:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Docusaurus builds are broken on main
3 participants
@JoshuaKGoldberg @Josh-Cena @rubiesonthesky