Skip to content

Revert "feat(typescript-estree): add EXPERIMENTAL_useProjectService option to use TypeScript project service" #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "feat(typescript-estree): add EXPERIMENTAL_useProjectService option to use TypeScript project service" #7251

wants to merge 1 commit into from

Conversation

JoshuaKGoldberg
Copy link
Member

Reverts #6754.

Fixes #7246.

@JoshuaKGoldberg
Revert "feat(typescript-estree): add EXPERIMENTAL_useProjectService o…
726a2c4 
…ption to use TypeScript project service (#6754)"

This reverts commit 6d3d162.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 726a2c4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b54285755a15000894c910
😎 Deploy Preview https://deploy-preview-7251--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Jul 17, 2023 •
edited
Loading

I'm trying this out locally on the TypeScript repo to make sure it fixes the issue...

Edit: it does.

@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 726a2c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 17, 2023
Closed
4 tasks
bradzacher
bradzacher reviewed Jul 17, 2023
View reviewed changes
packages/typescript-estree/src/create-program/getWatchProgramsForProjects.ts
Comment on lines -264 to -267
{
...ts.sys,
getCurrentDirectory: () => parseSettings.tsconfigRootDir,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this change that broke it??

Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh maybe! I'll try it out.

Still going to merge this PR just to be safe. Now that we know there's at least one untested thing I want to be more thorough in trying this out in other community repos. Talked with Brad - this is one of the few touches to existing code, and seems to be the most impactful. We'll go with just fixing this one spot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha. Yes, it does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7252

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #7251 (726a2c4) into main (74927c1) will increase coverage by 0.10%.
The diff coverage is 90.90%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7251      +/-   ##
==========================================
+ Coverage   87.47%   87.58%   +0.10%     
==========================================
  Files         379      377       -2     
  Lines       13234    13205      -29     
  Branches     3906     3901       -5     
==========================================
- Hits        11577    11565      -12     
+ Misses       1279     1261      -18     
- Partials      378      379       +1
Flag Coverage Δ
unittest 87.58% <90.90%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/create-program/getWatchProgramsForProjects.ts 84.83% <ø> (+2.70%) ⬆️
...t-estree/src/create-program/useProvidedPrograms.ts 84.84% <66.66%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts 97.72% <100.00%> (-0.06%) ⬇️
packages/typescript-estree/src/clear-caches.ts 100.00% <100.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 97.67% <100.00%> (+0.11%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 77.50% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 81.63% <100.00%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 17, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-6754-create-project-service branch June 22, 2024 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @bradzacher