Skip to content

fix(eslint-plugin): [non-nullable-type-assertion-style] consider operator precedence when fixing #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix(eslint-plugin): [non-nullable-type-assertion-style] consider operator precedence when fixing #7289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b9bc12
fix(eslint-plugin): [non-nullable-type-assertion-style] consider oper…
auvred Jul 21, 2023
78fe250
test: split huge test case
auvred Jul 26, 2023
650c990
Merge branch 'main' into fix/7243
auvred Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/eslint-plugin/src/rules/non-nullable-type-assertion-style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,21 @@ export default util.createRule({
}

if (sameTypeWithoutNullish(assertedTypes, originalTypes)) {
const expressionSourceCode = sourceCode.getText(node.expression);

const higherPrecedenceThanUnary =
util.getOperatorPrecedence(
services.esTreeNodeToTSNodeMap.get(node.expression).kind,
ts.SyntaxKind.Unknown,
) > util.OperatorPrecedence.Unary;

context.report({
fix(fixer) {
return fixer.replaceText(
node,
`${sourceCode.getText(node.expression)}!`,
higherPrecedenceThanUnary
? `${expressionSourceCode}!`
: `(${expressionSourceCode})!`,
);
},
messageId: 'preferNonNullAssertion',
Expand Down
42 changes: 42 additions & 0 deletions packages/eslint-plugin/tests/rules/non-nullable-type-assertion-style.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,48 @@ declare const x: T;
const y = x!;
`,
},
{
code: `
declare function nullablePromise(): Promise<string | null>;

async function fn(): Promise<string> {
return (await nullablePromise()) as string;
}
`,
errors: [
{
column: 10,
line: 5,
messageId: 'preferNonNullAssertion',
},
],
output: `
declare function nullablePromise(): Promise<string | null>;

async function fn(): Promise<string> {
return (await nullablePromise())!;
}
`,
},
{
code: `
declare const a: string | null;

const b = (a || undefined) as string;
`,
errors: [
{
column: 11,
line: 4,
messageId: 'preferNonNullAssertion',
},
],
output: `
declare const a: string | null;

const b = (a || undefined)!;
`,
},
],
});

Expand Down