Skip to content

fix(eslint-plugin): add main to package.json to support commonjs #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ghmcadams
Copy link

PR Checklist

Overview

Adds main to the package.json file in order to support older versions of node and related tools. Find further information in the issue I created (#7300 (Enable commonjs require by adding main to package.json))

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ghmcadams!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f88fb1d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64bd66bbce3e9a0008c0ed9e
😎 Deploy Preview https://deploy-preview-7301--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghmcadams ghmcadams changed the title Add main to package.json to support commonjs fix [eslint-plugin]: Add main to package.json to support commonjs Jul 23, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f88fb1d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@ghmcadams ghmcadams changed the title fix [eslint-plugin]: Add main to package.json to support commonjs fix (eslint-plugin): Add main to package.json to support commonjs Jul 23, 2023
@ghmcadams ghmcadams changed the title fix (eslint-plugin): Add main to package.json to support commonjs fix: [eslint-plugin]Add main to package.json to support commonjs Jul 23, 2023
@ghmcadams ghmcadams changed the title fix: [eslint-plugin]Add main to package.json to support commonjs fix(eslint-plugin): add main to package.json to support commonjs Jul 23, 2023
@bradzacher bradzacher closed this Jul 23, 2023
@bradzacher
Copy link
Member

Closing pending discussion on the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Enable commonjs require by adding main to package.json
2 participants