chore: enabled most of strict-type-checked internally #7339
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
737cbf1 to
27ff54b
Compare
packages/eslint-plugin/src/rules/naming-convention-utils/enums.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/naming-convention-utils/parse-options.ts
Show resolved
Hide resolved
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable @typescript-eslint/prefer-literal-enum-member */ | |||
There was a problem hiding this comment.
enum ArgumentType {
Other = 0,
String = 1 << 0,
RegExp = 1 << 1,
Both = String | RegExp,
}🤮
There was a problem hiding this comment.
Doesn't it make you feel like a pro? 😎
| string, | ||
| TSESLint.RuleModule<string, readonly unknown[], TSESLint.RuleListener>, | ||
| ]; | ||
| type RuleEntry = [string, TSESLint.RuleModule<string, readonly unknown[]>]; |
There was a problem hiding this comment.
TODO - should really migrate to import { RuleModule } from '@typescript-eslint/utils/ts-eslint'
That was the entire reason for adding the export maps
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
PR Checklist
Overview
Ran
yarn lint --fixand disabled a couple rules with a lot of complaints.