Skip to content

docs: remove duplicated package versions description #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2023
Merged

docs: remove duplicated package versions description #7343

merged 4 commits into from
Jul 28, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 27, 2023

PR Checklist

Overview

Reverting hunk from this merge commit c233652, according to #7341 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 48c4474
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64c41b3061290f00080d3e2b
😎 Deploy Preview https://deploy-preview-7343--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 48c4474. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this! I think the general direction is good, but because of the merge shenanigans there's additional info on this page we'd want to preserve.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jul 27, 2023
@auvred auvred mentioned this pull request Jul 28, 2023
Merged
6 tasks
@auvred auvred requested a review from JoshuaKGoldberg July 28, 2023 18:51
@auvred
Copy link
Member Author

auvred commented Jul 28, 2023

I guess I added all missed stuff :)

@auvred @JoshuaKGoldberg
Update docs/users/Versioning.mdx
07279d1 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close! Just a bit more stuff that I don't see in the new form. I think we'll be good to go once that's added back in (or I'm told I just did a silly and missed them?). 🚀

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #7343 (48c4474) into main (54ef459) will increase coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7343      +/-   ##
==========================================
+ Coverage   87.40%   87.41%   +0.01%     
==========================================
  Files         381      381              
  Lines       13313    13316       +3     
  Branches     3934     3936       +2     
==========================================
+ Hits        11636    11640       +4     
- Misses       1292     1298       +6     
+ Partials      385      378       -7
Flag Coverage Δ
unittest 87.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@auvred
Copy link
Member Author

auvred commented Jul 28, 2023

Excuse me for my inattention, documentation is not my strongest point 😓

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 33b936d into typescript-eslint:main Jul 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Two pages describe package versions
2 participants
@auvred @JoshuaKGoldberg