Skip to content

docs: mention EXPERIMENTAL_useProjectService in parser package docs #7352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Provides a summary of how to use the option, why it's promising, and a back-link to #6754.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9e77dd2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64c31273164b1100083c5ae0
😎 Deploy Preview https://deploy-preview-7352--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bradzacher
bradzacher previously approved these changes Jul 28, 2023
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jul 28, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9e77dd2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.


We're hopeful this option will eventually become the standard way to enable typed linting.
It switches the parser from manually creating TypeScript programs to instead calling the same "project services" API used by editors such as VS Code.
However, because it's so new and untested, we're keeping it under the `EXPERIMENTAL_` prefix for at least all of the `6.X` versions.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @jakebailey, just in case our phrasing is offputting for TypeScript-ers. I have a reminder set to merge this in time for our weekly deployment on Monday.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #7352 (9e77dd2) into main (54ef459) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7352   +/-   ##
=======================================
  Coverage   87.40%   87.41%           
=======================================
  Files         381      381           
  Lines       13313    13313           
  Branches     3934     3934           
=======================================
+ Hits        11636    11637    +1     
- Misses       1292     1298    +6     
+ Partials      385      378    -7     
Flag Coverage Δ
unittest 87.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7586fd2 into typescript-eslint:main Jul 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the parser-experimental-use-project-service-docs branch July 31, 2023 08:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add mention of EXPERIMENTAL_useProjectService to parser docs
2 participants