Skip to content

fix(eslint-plugin): [no-restricted-imports] allow inline type qualifiers when allowTypeImports enabled #7379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2023
Merged

fix(eslint-plugin): [no-restricted-imports] allow inline type qualifiers when allowTypeImports enabled #7379

merged 2 commits into from
Aug 5, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Jul 30, 2023

PR Checklist

Overview

If kind of every specifier in import/export declaration is type, then the entire declaration is treated as type-only

The issue was about exports, but I guess this should be applicable to imports too

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 30, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f99bfe1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64cea73d226ed80008a0a9fc
😎 Deploy Preview https://deploy-preview-7379--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 30, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f99bfe1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Merging #7379 (43f4e57) into main (c869aa1) will increase coverage by 0.01%.
Report is 40 commits behind head on main.
The diff coverage is 67.56%.

❗ Current head 43f4e57 differs from pull request most recent head f99bfe1. Consider uploading reports for the commit f99bfe1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7379      +/-   ##
==========================================
+ Coverage   87.40%   87.41%   +0.01%     
==========================================
  Files         381      381              
  Lines       13313    13321       +8     
  Branches     3934     3939       +5     
==========================================
+ Hits        11636    11645       +9     
- Misses       1292     1298       +6     
+ Partials      385      378       -7
Flag Coverage Δ
unittest 87.41% <67.56%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...kages/scope-manager/src/referencer/ClassVisitor.ts 91.73% <ø> (ø)
packages/type-utils/src/predicates.ts 21.73% <0.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <ø> (ø)
packages/typescript-estree/src/convert.ts 30.03% <31.25%> (ø)
...eslint-plugin/src/rules/type-annotation-spacing.ts 83.09% <50.00%> (+1.40%) ⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts 94.50% <100.00%> (ø)
packages/eslint-plugin/src/rules/indent.ts 88.09% <100.00%> (ø)
packages/eslint-plugin/src/rules/key-spacing.ts 99.30% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <100.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 95.23% <100.00%> (+0.23%) ⬆️
... and 10 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black and white music video shot of Beyonce saying 'flawless'

@JoshuaKGoldberg JoshuaKGoldberg merged commit cc9a46d into typescript-eslint:main Aug 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-restricted-imports] allowTypeImports should allow inline type qualifiers
2 participants
@auvred @JoshuaKGoldberg