Skip to content

feat(typescript-estree): update type annotation in index signature #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2019
Merged

feat(typescript-estree): update type annotation in index signature #74

merged 2 commits into from
Jan 19, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 19, 2019

This PR corrects order of visiting properties in TSIndexSignature and makes typeAnnotation property undefined when node is not present

@armano2 armano2 requested a review from JamesHenry January 19, 2019 01:18
@armano2 armano2 changed the title chore(typescript-estree): update type annotation in index signature feat(typescript-estree): update type annotation in index signature Jan 19, 2019
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #74 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   94.77%   94.77%   +<.01%     
==========================================
  Files          48       48              
  Lines        2469     2470       +1     
  Branches      381      381              
==========================================
+ Hits         2340     2341       +1     
  Misses         77       77              
  Partials       52       52
Impacted Files Coverage Δ
...kages/typescript-eslint-parser/src/visitor-keys.ts 100% <ø> (ø) ⬆️
packages/typescript-estree/src/convert.ts 94.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8187ac...9791572. Read the comment docs.

@JamesHenry JamesHenry merged commit ab64809 into typescript-eslint:master Jan 19, 2019
@armano2 armano2 deleted the index-signature branch January 19, 2019 05:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants