Skip to content

feat(eslint-plugin): [await-thenable] added suggestion fixer #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2023
Merged

feat(eslint-plugin): [await-thenable] added suggestion fixer #7437

merged 2 commits into from
Sep 8, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a suggestion fixer to remove await from the beginning of the AwaitExpression.

While I was in the area, split up the invalid test cases (#6887).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 73d4a8c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64f3fdb47a49110008f9bf37
😎 Deploy Preview https://deploy-preview-7437--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 7, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 73d4a8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #7437 (73d4a8c) into main (0a1de14) will decrease coverage by 0.19%.
Report is 76 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7437      +/-   ##
==========================================
- Coverage   87.41%   87.23%   -0.19%     
==========================================
  Files         381      387       +6     
  Lines       13321    13404      +83     
  Branches     3938     3962      +24     
==========================================
+ Hits        11645    11693      +48     
- Misses       1298     1327      +29     
- Partials      378      384       +6
Flag Coverage Δ
unittest 87.23% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

armano2
armano2 previously approved these changes Sep 2, 2023
View reviewed changes
@bradzacher bradzacher changed the title feat(eslint-plugin): added suggestion fixer to await-thenable feat(eslint-plugin): [await-thenable] added suggestion fixer Sep 7, 2023
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 7, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit b284370 into typescript-eslint:main Sep 8, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the await-thenable-fixer branch September 8, 2023 11:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@armano2 armano2 armano2 left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [await-thenable] Add a suggestion fixer
3 participants
@JoshuaKGoldberg @armano2 @bradzacher