Skip to content

chore: add rule-tester commit scope #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

chore: add rule-tester commit scope #7468

merged 1 commit into from
Aug 15, 2023

Conversation

azat-io
Copy link
Contributor

@azat-io azat-io commented Aug 13, 2023

PR Checklist

Overview

In version 6.0, a new rule-tester package was added.

It's worth adding this scope to the commit validator. My other PR crashed with an error because of it:
#7467

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 18bb852
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64db9897b04ef4000848064b
😎 Deploy Preview https://deploy-preview-7468--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 13, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18bb852. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 37 targets

Sent with 💌 from NxCloud.

@azat-io azat-io changed the title ci: add rule-tester commit scope chore: add rule-tester commit scope Aug 13, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! Nice catch :)

@JoshuaKGoldberg JoshuaKGoldberg merged commit 951a3bb into typescript-eslint:main Aug 15, 2023
@azat-io azat-io deleted the ci/rule-tester branch August 15, 2023 20:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants