typescript-eslint · JamesHenry · Jan 19, 2019 · Jan 19, 2019
diff --git a/packages/eslint-plugin-typescript/lib/rules/class-name-casing.js b/packages/eslint-plugin-typescript/lib/rules/class-name-casing.js
@@ -54,10 +54,7 @@ module.exports = {
       switch (decl.type) {
         case 'ClassDeclaration':
         case 'ClassExpression':
-          friendlyName = 'Class';
-          break;
-        case 'TSAbstractClassDeclaration':
-          friendlyName = 'Abstract class';
+          friendlyName = decl.abstract ? 'Abstract class' : 'Class';
           break;
         case 'TSInterfaceDeclaration':
           friendlyName = 'Interface';
@@ -81,9 +78,7 @@ module.exports = {
     //----------------------------------------------------------------------
 
     return {
-      'ClassDeclaration, TSInterfaceDeclaration, TSAbstractClassDeclaration, ClassExpression'(
-        node
-      ) {
+      'ClassDeclaration, TSInterfaceDeclaration, ClassExpression'(node) {
         // class expressions (i.e. export default class {}) are OK
         if (node.id && !isPascalCase(node.id.name)) {
           report(node);

diff --git a/packages/eslint-plugin-typescript/lib/rules/indent.js b/packages/eslint-plugin-typescript/lib/rules/indent.js
@@ -29,7 +29,6 @@ const KNOWN_NODES = new Set([
   'TSNullKeyword',
 
   // ts specific nodes we want to support
-  'TSAbstractClassDeclaration',
   'TSAbstractClassProperty',
   'TSAbstractMethodDefinition',
   'TSArrayType',

diff --git a/packages/eslint-plugin-typescript/tests/lib/eslint-rules/no-shadow.js b/packages/eslint-plugin-typescript/tests/lib/eslint-rules/no-shadow.js
@@ -22,6 +22,11 @@ ruleTester.run('no-shadow', rule, {
     `
 type foo = any;
 function bar(foo: any) {}
+    `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/20
+    `
+export abstract class Foo {}
+export class FooBar extends Foo {}
     `
   ],
   invalid: []

diff --git a/packages/eslint-plugin-typescript/tests/lib/eslint-rules/no-undef.js b/packages/eslint-plugin-typescript/tests/lib/eslint-rules/no-undef.js
@@ -61,6 +61,11 @@ interface Runnable {
 export type SomeThing = {
     id: string;
 }
+    `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/20
+    `
+export abstract class Foo {}
+export class FooBar extends Foo {}
     `
   ],
   invalid: []

diff --git a/packages/eslint-plugin-typescript/tests/lib/rules/indent.js b/packages/eslint-plugin-typescript/tests/lib/rules/indent.js
@@ -22,7 +22,7 @@ function nonTsTestCase(example) {
 
 const individualNodeTests = [
   {
-    node: 'TSAbstractClassDeclaration',
+    node: 'ClassDeclaration',
     code: [
       `
 abstract class Foo {
@@ -157,7 +157,7 @@ interface Foo {
     ]
   },
   {
-    node: 'TSEmptyBodyDeclareFunction',
+    node: 'TSDeclareFunction',
     code: [
       `
 declare function foo() : {

diff --git a/packages/typescript-eslint-parser/src/analyze-scope.ts b/packages/typescript-eslint-parser/src/analyze-scope.ts
@@ -202,7 +202,7 @@ class Referencer extends OriginalReferencer {
   /**
    * Override.
    * Visit decorators.
-   * @param {ClassDeclaration|ClassExpression|TSAbstractClassDeclaration} node The class node to visit.
+   * @param {ClassDeclaration|ClassExpression} node The class node to visit.
    * @returns {void}
    */
   visitClass(node: any) {
@@ -709,9 +709,6 @@ class Referencer extends OriginalReferencer {
     this.close(node);
   }
 
-  TSAbstractClassDeclaration(node: any) {
-    this.ClassDeclaration(node);
-  }
   TSAbstractClassProperty(node: any) {
     this.ClassProperty(node);
   }

diff --git a/packages/typescript-eslint-parser/src/visitor-keys.ts b/packages/typescript-eslint-parser/src/visitor-keys.ts
@@ -36,15 +36,6 @@ export const visitorKeys = eslintVisitorKeys.unionWith({
   ClassProperty: ['decorators', 'key', 'typeAnnotation', 'value'],
   Decorator: ['expression'],
   TSAbstractClassProperty: ['decorators', 'key', 'typeAnnotation', 'value'],
-  TSAbstractClassDeclaration: [
-    'decorators',
-    'id',
-    'typeParameters',
-    'superClass',
-    'superTypeParameters',
-    'implements',
-    'body'
-  ],
   TSAbstractKeyword: [],
   TSAbstractMethodDefinition: ['key', 'value'],
   TSAnyKeyword: [],