feat: bump supported TS version to 5.2 #7535

bradzacher · 2023-08-25T00:15:48Z

PR Checklist

Addresses an existing open issue: fixes TypeScript 5.2 Support #7155
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

bump the version
regenerate lib types
regenerate playground types

typescript-eslint · 2023-08-25T00:15:50Z

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-08-25T00:15:53Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`7251239`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64e7fca7df00050007239065
😎 Deploy Preview	https://deploy-preview-7535--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2023-08-25T00:18:42Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7251239. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

codecov · 2023-08-25T00:38:21Z

Codecov Report

Merging #7535 (7251239) into main (c11e05c) will increase coverage by 2.11%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7535      +/-   ##
==========================================
+ Coverage   85.10%   87.22%   +2.11%     
==========================================
  Files         386      386              
  Lines       13383    13383              
  Branches     3955     3955              
==========================================
+ Hits        11390    11673     +283     
+ Misses       1614     1328     -286     
- Partials      379      382       +3

Flag	Coverage Δ
unittest	`87.22% <100.00%> (+2.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts	`93.33% <100.00%> (ø)`

... and 7 files with indirect coverage changes

JoshuaKGoldberg · 2023-08-25T17:03:06Z

packages/scope-manager/tools/generate-lib.ts

+  console.error(e);
+  // eslint-disable-next-line no-process-exit
+  process.exit(1);
+});


What's going on here? Is it related to #7534?

Nah so I ran the generator and noticed that it changed all of the lib files and caused a bunch of lint errors due to unsorted imports and such.

I figured that instead of manually running the linter afterwards was dumb cos we can automate it :)

JoshuaKGoldberg

🚀

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.4.1/6.5.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.4.1/6.5.0) | | [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.4.1` -> `6.5.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2ftypescript-estree/6.4.1/6.5.0) | | [netlify-cli](https://github.com/netlify/cli) | devDependencies | minor | [`16.1.0` -> `16.2.0`](https://renovatebot.com/diffs/npm/netlify-cli/16.1.0/16.2.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#650-2023-08-28) [Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0) ##### Bug Fixes - **eslint-plugin:** \[consistent-type-assertions] wrap object return value with parentheses ([#6885](typescript-eslint/typescript-eslint#6885)) ([23ac499](typescript-eslint/typescript-eslint@23ac499)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21) ##### Bug Fixes - **eslint-plugin:** \[no-unnecessary-condition] false positives with branded types ([#7466](typescript-eslint/typescript-eslint#7466)) ([b52658f](typescript-eslint/typescript-eslint@b52658f)), closes [#7293](typescript-eslint/typescript-eslint#7293) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#650-2023-08-28) [Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/typescript-estree)</summary> ### [`v6.5.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-estree/CHANGELOG.md#650-2023-08-28) [Compare Source](typescript-eslint/typescript-eslint@v6.4.1...v6.5.0) ##### Features - bump supported TS version to 5.2 ([#7535](typescript-eslint/typescript-eslint#7535)) ([f18c88d](typescript-eslint/typescript-eslint@f18c88d)) - support Explicit Resource Management syntax for TS 5.2 ([#7479](typescript-eslint/typescript-eslint#7479)) ([c11e05c](typescript-eslint/typescript-eslint@c11e05c)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. #### [6.4.1](typescript-eslint/typescript-eslint@v6.4.0...v6.4.1) (2023-08-21) **Note:** Version bump only for package [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-estree) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>netlify/cli (netlify-cli)</summary> ### [`v16.2.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1620-2023-08-29) [Compare Source](netlify/cli@v16.1.0...v16.2.0) ##### Features - add support for `context.params` in edge functions ([#5964](netlify/cli#5964)) ([ed14e05](netlify/cli@ed14e05)) - support custom function routes ([#5954](netlify/cli#5954)) ([82b94b5](netlify/cli@82b94b5)) ##### Bug Fixes - **deps:** update dependency [@netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.18.0 ([#5953](netlify/cli#5953)) ([016cdf9](netlify/cli@016cdf9)) - **deps:** update dependency [@netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.19.0 ([#5971](netlify/cli#5971)) ([42478fd](netlify/cli@42478fd)) - **deps:** update dependency [@netlify/serverless-functions-api](https://github.com/netlify/serverless-functions-api) to v1.6.0 ([#5935](netlify/cli#5935)) ([1d68354](netlify/cli@1d68354)) - **deps:** update dependency [@netlify/serverless-functions-api](https://github.com/netlify/serverless-functions-api) to v1.7.3 ([#5957](netlify/cli#5957)) ([57d6627](netlify/cli@57d6627)) - **deps:** update dependency lambda-local to v2.1.2 ([#5967](netlify/cli#5967)) ([e592944](netlify/cli@e592944)) - **deps:** update netlify packages ([#5915](netlify/cli#5915)) ([1ad27ac](netlify/cli@1ad27ac)) - **deps:** update netlify packages ([#5965](netlify/cli#5965)) ([654c366](netlify/cli@654c366)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3pm on Sunday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.chriswb.dev/chrisw-b/PersonalApi/pulls/3 Reviewed-by: chrisw-b <chrisw-b@noreply.localhost> Co-authored-by: Renovate Bot <renovate.bot@chrisb.xyz> Co-committed-by: Renovate Bot <renovate.bot@chrisb.xyz>

armano2 · 2023-09-05T01:25:58Z

packages/scope-manager/tools/generate-lib.ts

@@ -1,5 +1,6 @@
 import type { TSESTree } from '@typescript-eslint/types';
 import { AST_TOKEN_TYPES } from '@typescript-eslint/types';
+import { ESLint } from '@typescript-eslint/utils/ts-eslint';


@bradzacher this seem to be generating some issues on clean install

> yarn build NX Could not execute command because the task graph has a circular dependency rule-schema-to-typescript-types:build --> type-utils:build --> utils:build --> scope-manager:build --> utils:build

feat: bump supported TS version to 5.2

9da0b8d

bradzacher added dependencies Issue about dependencies of the package New TypeScript Version labels Aug 25, 2023

lint fix generated code

7251239

JoshuaKGoldberg reviewed Aug 25, 2023

View reviewed changes

JoshuaKGoldberg approved these changes Aug 25, 2023

View reviewed changes

bradzacher merged commit f18c88d into main Aug 25, 2023

bradzacher deleted the ts-5-2-bump branch August 25, 2023 21:55

github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023

armano2 reviewed Sep 5, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: bump supported TS version to 5.2 #7535

feat: bump supported TS version to 5.2 #7535

bradzacher commented Aug 25, 2023

typescript-eslint bot commented Aug 25, 2023

netlify bot commented Aug 25, 2023 •

edited

Loading

nx-cloud bot commented Aug 25, 2023 •

edited

Loading

codecov bot commented Aug 25, 2023 •

edited

Loading

JoshuaKGoldberg Aug 25, 2023

bradzacher Aug 25, 2023

JoshuaKGoldberg left a comment

armano2 Sep 5, 2023 •

edited

Loading

feat: bump supported TS version to 5.2 #7535

feat: bump supported TS version to 5.2 #7535

Conversation

bradzacher commented Aug 25, 2023

PR Checklist

Overview

typescript-eslint bot commented Aug 25, 2023

netlify bot commented Aug 25, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Aug 25, 2023 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Aug 25, 2023 • edited Loading

Codecov Report

JoshuaKGoldberg Aug 25, 2023

Choose a reason for hiding this comment

bradzacher Aug 25, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

armano2 Sep 5, 2023 • edited Loading

Choose a reason for hiding this comment

netlify bot commented Aug 25, 2023 •

edited

Loading

nx-cloud bot commented Aug 25, 2023 •

edited

Loading

codecov bot commented Aug 25, 2023 •

edited

Loading

armano2 Sep 5, 2023 •

edited

Loading