Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(eslint-plugin): [switch-exhaustiveness-check] add an option to warn against a
default
case on an already exhaustiveswitch
#7539New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [switch-exhaustiveness-check] add an option to warn against a
default
case on an already exhaustiveswitch
#7539Changes from all commits
af5eda0
12a7635
729378f
329c99e
7fc2823
4a5002e
1c2f06c
0e5afe5
99ef806
c7ca234
5709fe3
074905f
81b4400
7729224
592de1d
26a9919
e865d6b
5be7b48
d18f0f1
4091daf
d68f7b7
1fa4494
22c1503
c928b18
c32204e
6ea1b32
090a737
b93f501
0fe1cd9
cab680a
8ad5037
4aa247b
9a63489
30b6695
5a3bf3c
e1e8554
7dbafe5
d0611cb
2c6dfb4
279aa9c
29284b2
8e24cfb
9fda18d
24327c4
c4a7646
e5f0587
75e3015
6e427b4
8d8bba6
fbc3f3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Docs] What do you think about providing a correct / incorrect tab here? I believe most options these days do, and they're useful for users.
I separately posted #8014 (comment) that we might eventually lint/test to enforce this practice. So no worries if you don't have the time or a good example isn't quick to write. Non-blocking IMO 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #8154 as a followup 👍