Skip to content

fix(typescript-estree): disallow using as the variable keyword for for..in loops #7649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 12, 2024
Merged

fix(typescript-estree): disallow using as the variable keyword for for..in loops #7649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ff2a22
feat: check declaration in for init, make sure no using keyword show up
Solo-steven Sep 15, 2023
a725c38
feat: check declaration in for init, make sure no using keyword show up
Solo-steven Sep 15, 2023
d4cfaa0
Merge branch 'steven/issue-7555' of github.com:Solo-steven/typescript…
Solo-steven Sep 15, 2023
8ca11fb
fix(typescript-estree): allow for and for-of statement have using key…
Solo-steven Oct 21, 2023
6fc8662
fix(typescript-estree): shorten for in statement check condition, mov…
Solo-steven Jan 9, 2024
acdd3c1
Update 1-TSESTree-Error.shot
bradzacher Jan 11, 2024
908aea3
Merge branch 'main' into steven/issue-7555
bradzacher Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ast-spec/src/statement/ForInStatement/fixtures/_error_/using-initializer/fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
for(using foo in {});
7 changes: 7 additions & 0 deletions ...atement/ForInStatement/fixtures/_error_/using-initializer/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .../statement/ForInStatement/fixtures/_error_/using-initializer/snapshots/2-Babel-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ...tement/ForInStatement/fixtures/_error_/using-initializer/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions packages/typescript-estree/src/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,6 +933,7 @@ export class Converter {
});

case SyntaxKind.ForInStatement:
this.#checkForStatementDeclaration(node.initializer);
return this.createNode<TSESTree.ForInStatement>(node, {
type: AST_NODE_TYPES.ForInStatement,
left: this.convertPattern(node.initializer),
Expand Down Expand Up @@ -3510,4 +3511,14 @@ export class Converter {

throw createError(message, this.ast, start, end);
}
#checkForStatementDeclaration(initializer: ts.ForInitializer): void {
if (ts.isVariableDeclarationList(initializer)) {
if ((initializer.flags & ts.NodeFlags.Using) !== 0) {
this.#throwError(
initializer,
"The left-hand side of a 'for...in' statement cannot be a 'using' declaration.",
);
}
}
}
}