Skip to content

fix(utils): type portability with RuleCreator, fix #7605 #7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

fix(utils): type portability with RuleCreator, fix #7605 #7690

merged 1 commit into from
Sep 23, 2023

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Sep 23, 2023 •
edited
Loading

PR Checklist

Overview

Reproduction: https://github.com/antfu/repro-ts-eslint-utils-dts - fails on both tsup and unbuild

Reproduction with patch: https://github.com/antfu/repro-ts-eslint-utils-dts/tree/patched (the patched branch) - both tsup and unbuild work correctly and generated the following dts:

import { ESLintUtils } from '@typescript-eslint/utils';

declare const _default: ESLintUtils.RuleModule<"missingIfNewline", [], ESLintUtils.RuleListener>;

export { _default as default };

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @antfu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 318b0a5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/650e9a8b4ff08e0008760a9a
😎 Deploy Preview https://deploy-preview-7690--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu antfu mentioned this pull request Sep 23, 2023
Closed
2 tasks
@nx-cloud
Copy link

nx-cloud bot commented Sep 23, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 318b0a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks! ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4e23591 into typescript-eslint:main Sep 23, 2023
@antfu antfu deleted the fix/utils-types-portable branch September 23, 2023 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Explain how to get around "not portable" TypeScript type errors
2 participants
@antfu @JoshuaKGoldberg