Skip to content

fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 17, 2023
Merged

fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set #7705

merged 5 commits into from
Nov 17, 2023

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Sep 30, 2023 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This fixes #7704.

TypeScript's interface feature does not have any private/protected member as a part of it.

So the rule class-methods-use-this enabling ignoreClassesThatImplementAnInterface=true should warn the case of that the implementation is not a part of interface.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tetsuharuohzeki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 30, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit be7c886
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6557ebe495ba9600084d121a
😎 Deploy Preview https://deploy-preview-7705--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 30, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3625d70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@tetsuharuohzeki tetsuharuohzeki marked this pull request as ready for review September 30, 2023 05:27
@tetsuharuohzeki tetsuharuohzeki force-pushed the fix-7704-class-methods-use-this branch from 4d4e714 to d4b5aaf Compare October 18, 2023 04:18
@JoshuaKGoldberg
Copy link
Member

Converting to draft since the linked issue hasn't been accepted yet. Let's continue conversation there.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft October 19, 2023 15:53
@tetsuharuohzeki tetsuharuohzeki force-pushed the fix-7704-class-methods-use-this branch 2 times, most recently from 80b3efe to 3625d70 Compare October 24, 2023 21:26
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 17, 2023 18:06
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! This looks great to me - just one docs suggestion from me. What do you think @tetsuharuohzeki?

Thanks for waiting btw - I'm excited about this option!

packages/eslint-plugin/tests/schema-snapshots/class-methods-use-this.shot Outdated
Comment on lines 55 to 56
| 'public-fields'
/** Ignore classes that specifically implement some interface */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this looks a little off... outside the scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to remove its comment but I seem nx run eslint-plugin:test generate it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add more descriptions but it cannot remove extra comments.
7390468

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is just something odd in the repository, separate from your changes. No worries. Thanks for trying though!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 17, 2023
@tetsuharuohzeki tetsuharuohzeki force-pushed the fix-7704-class-methods-use-this branch from 3625d70 to 7390468 Compare November 17, 2023 20:40
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

@JoshuaKGoldberg
Copy link
Member

I introduced a merge conflict on main and can fix it :)

@tetsuharuohzeki tetsuharuohzeki changed the title fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is true fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members if ignoreClassesThatImplementAnInterface is set Nov 17, 2023
@tetsuharuohzeki tetsuharuohzeki force-pushed the fix-7704-class-methods-use-this branch from 42e2148 to b7beb57 Compare November 17, 2023 22:25
@tetsuharuohzeki
Copy link
Contributor Author

@JoshuaKGoldberg

Thank you for your review! I rebase my change sets on the latest main!

@JoshuaKGoldberg
Copy link
Member

Amazing, thanks! Saved me a bit of time wrestling with it locally. 🙂

@JoshuaKGoldberg JoshuaKGoldberg merged commit 155aa1f into typescript-eslint:main Nov 17, 2023
@tetsuharuohzeki tetsuharuohzeki deleted the fix-7704-class-methods-use-this branch November 17, 2023 23:02
@tetsuharuohzeki
Copy link
Contributor Author

@JoshuaKGoldberg Thank you for accepting my patch.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
2 participants
@tetsuharuohzeki @JoshuaKGoldberg