fix(eslint-plugin): [no-unnecessary-condition] fix false positive with computed member access and branded key type #7706
Conversation
|
Thanks for the PR, @yf-yang! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Btw, the Netlify failures are unrelated to this PR. You should be able to ignore them. |
|
Just curious 👀 , you are using squash and merge option, so only the PR title should follow conventional commit guidelines, the commit messages don't matter, right? |
That's right. You can do whatever you want with commit titles and commit as many times as you want. |
…h computed member access and branded key type
…ses for branded key type's index access
PR Checklist
Overview
TypeScript's
getIndexInfoOfTypeonly accepts purestringornumbertype, so instead we extract all the index infos and compare their keyType by getting the type name of the key type.