Skip to content

chore: remove Playwright end-to-end website tests #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -240,59 +240,6 @@ jobs:
CI: true
TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER: true

website_tests:
permissions:
contents: read # to fetch code (actions/checkout)

name: Website tests
# We technically do not need to wait for build within the pipeline any more because the build we care about is happening within Netlify, however,
# it is highly likely that if the CI one fails, the Netlify one will as well, so in order to not waste unncessary Github Actions minutes/resources,
# we do still keep this requirement here.
needs: [build]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 2

- name: Install
uses: ./.github/actions/prepare-install
with:
node-version: ${{ env.PRIMARY_NODE_VERSION }}

- name: Build website
if: github.repository != 'typescript-eslint/typescript-eslint' || github.ref != 'refs/heads/main'
run: NX_VERBOSE_LOGGING=true yarn nx build website

- name: Install Playwright Browsers
run: npx playwright install --with-deps chromium

- name: Wait for Netlify deployment
if: github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main'
uses: ./.github/actions/wait-for-netlify
id: waitForDeployment
with:
netlify_token: ${{ secrets.NETLIFY_TOKEN }}

- name: Run Playwright tests against the Netlify deployment
if: github.repository == 'typescript-eslint/typescript-eslint' && github.ref == 'refs/heads/main'
run: yarn playwright test --reporter=list
working-directory: packages/website
env:
PLAYWRIGHT_TEST_BASE_URL: ${{ steps.waitForDeployment.outputs.url }}

- name: Run Playwright tests against local deployment
if: github.repository != 'typescript-eslint/typescript-eslint' || github.ref != 'refs/heads/main'
run: yarn playwright test --reporter=list
working-directory: packages/website

- if: always()
uses: actions/upload-artifact@v3
with:
name: playwright-report
path: packages/website/playwright-report

upload_coverage:
name: Upload Codecov Coverage
needs: [unit_tests]
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ yarn-error.log*
packages/website/.docusaurus
packages/website/.cache-loader
packages/website/build
packages/website/playwright-report
packages/website/playwright/.cache
packages/website/static/sandbox
packages/website/test-results

# Runtime data
pids
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ CHANGELOG.md

packages/website/.docusaurus
packages/website/build
packages/website/playwright-report

# see the file header in eslint-base.test.js for more info
packages/rule-tester/tests/eslint-base
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"start": "nx run website:start",
"test": "nx run-many --target=test --parallel --exclude integration-tests --exclude website --exclude website-eslint",
"test-integration": "nx run integration-tests:test",
"test-website": "nx run-many --target=test --projects=website,website-eslint",
"typecheck": "nx run-many --target=typecheck --parallel"
},
"engines": {
Expand Down
3 changes: 0 additions & 3 deletions packages/website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"serve": "docusaurus serve",
"start": "nx start",
"swizzle": "docusaurus swizzle",
"test": "playwright test",
"typecheck": "tsc -b ./tsconfig.json"
},
"dependencies": {
Expand Down Expand Up @@ -46,9 +45,7 @@
"react": "^18.2.0"
},
"devDependencies": {
"@axe-core/playwright": "^4.7.3",
"@docusaurus/module-type-aliases": "~2.4.1",
"@playwright/test": "^1.36.0",
"@types/react": "*",
"@types/react-helmet": "^6.1.6",
"@types/react-router-dom": "^5.3.3",
Expand Down
32 changes: 0 additions & 32 deletions packages/website/playwright.config.ts

This file was deleted.

38 changes: 0 additions & 38 deletions packages/website/tests/index.spec.ts

This file was deleted.

84 changes: 0 additions & 84 deletions packages/website/tests/playground.spec.ts

This file was deleted.

32 changes: 0 additions & 32 deletions packages/website/tests/rules.spec.ts

This file was deleted.

44 changes: 3 additions & 41 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -233,17 +233,6 @@ __metadata:
languageName: node
linkType: hard

"@axe-core/playwright@npm:^4.7.3":
version: 4.7.3
resolution: "@axe-core/playwright@npm:4.7.3"
dependencies:
axe-core: ^4.7.0
peerDependencies:
playwright-core: ">= 1.0.0"
checksum: c913cf6a816af283fc733411013460656213cf6c0efffcc36db1fd2984ffac3d780efd0a9aabd3b41ce78e2a536fee9ba5436d19311f660067e4c3560677b115
languageName: node
linkType: hard

"@babel/code-frame@npm:*, @babel/code-frame@npm:^7.0.0, @babel/code-frame@npm:^7.10.4, @babel/code-frame@npm:^7.12.13, @babel/code-frame@npm:^7.16.0, @babel/code-frame@npm:^7.22.13, @babel/code-frame@npm:^7.22.5, @babel/code-frame@npm:^7.8.3":
version: 7.22.13
resolution: "@babel/code-frame@npm:7.22.13"
Expand Down Expand Up @@ -4526,22 +4515,6 @@ __metadata:
languageName: node
linkType: hard

"@playwright/test@npm:^1.36.0":
version: 1.36.2
resolution: "@playwright/test@npm:1.36.2"
dependencies:
"@types/node": "*"
fsevents: 2.3.2
playwright-core: 1.36.2
dependenciesMeta:
fsevents:
optional: true
bin:
playwright: cli.js
checksum: 659304e0bbbafb2fa36395fbd8bd2c5db2b7791bbb55fa62409946ec7ec726cf8fff89f2b8a1a74fe831bf50a8780a37a5322a1251a6f7db2a9220a57ac408f0
languageName: node
linkType: hard

"@polka/url@npm:^1.0.0-next.20":
version: 1.0.0-next.21
resolution: "@polka/url@npm:1.0.0-next.21"
Expand Down Expand Up @@ -6935,7 +6908,7 @@ __metadata:
languageName: node
linkType: hard

"axe-core@npm:^4.6.2, axe-core@npm:^4.7.0":
"axe-core@npm:^4.6.2":
version: 4.7.2
resolution: "axe-core@npm:4.7.2"
checksum: 5d86fa0f45213b0e54cbb5d713ce885c4a8fe3a72b92dd915a47aa396d6fd149c4a87fec53aa978511f6d941402256cfeb26f2db35129e370f25a453c688655a
Expand Down Expand Up @@ -10991,7 +10964,7 @@ __metadata:
languageName: node
linkType: hard

"fsevents@npm:2.3.2, fsevents@npm:^2.3.2, fsevents@npm:~2.3.2":
"fsevents@npm:^2.3.2, fsevents@npm:~2.3.2":
version: 2.3.2
resolution: "fsevents@npm:2.3.2"
dependencies:
Expand All @@ -11001,7 +10974,7 @@ __metadata:
languageName: node
linkType: hard

"fsevents@patch:fsevents@2.3.2#~builtin<compat/fsevents>, fsevents@patch:fsevents@^2.3.2#~builtin<compat/fsevents>, fsevents@patch:fsevents@~2.3.2#~builtin<compat/fsevents>":
"fsevents@patch:fsevents@^2.3.2#~builtin<compat/fsevents>, fsevents@patch:fsevents@~2.3.2#~builtin<compat/fsevents>":
version: 2.3.2
resolution: "fsevents@patch:fsevents@npm%3A2.3.2#~builtin<compat/fsevents>::version=2.3.2&hash=df0bf1"
dependencies:
Expand Down Expand Up @@ -16342,15 +16315,6 @@ __metadata:
languageName: node
linkType: hard

"playwright-core@npm:1.36.2":
version: 1.36.2
resolution: "playwright-core@npm:1.36.2"
bin:
playwright-core: cli.js
checksum: 2193ce802ef93c28b9b5e11a0b1d7b60778c686015659978d1cbf0eb9cda2cdc85ec5575b887c1346e9d161cc2805bf27638d76a2f7f857dffeae968e6ceffcd
languageName: node
linkType: hard

"pluralize@npm:^8.0.0":
version: 8.0.0
resolution: "pluralize@npm:8.0.0"
Expand Down Expand Up @@ -20773,7 +20737,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "website@workspace:packages/website"
dependencies:
"@axe-core/playwright": ^4.7.3
"@babel/runtime": ^7.22.6
"@docusaurus/core": ~2.4.1
"@docusaurus/module-type-aliases": ~2.4.1
Expand All @@ -20782,7 +20745,6 @@ __metadata:
"@docusaurus/remark-plugin-npm2yarn": ~2.4.1
"@docusaurus/theme-common": ~2.4.1
"@mdx-js/react": 1.6.22
"@playwright/test": ^1.36.0
"@types/react": "*"
"@types/react-helmet": ^6.1.6
"@types/react-router-dom": ^5.3.3
Expand Down