Skip to content

chore: don't clear TSServer Project Service between repo tests #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: don't clear TSServer Project Service between repo tests #7801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/typescript-estree/src/clear-caches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import { clearWatchCaches } from './create-program/getWatchProgramsForProjects';
import { clearProgramCache as clearProgramCacheOriginal } from './parser';
import {
clearTSConfigMatchCache,
clearTSServerProjectService,
} from './parseSettings/createParseSettings';
import { clearTSConfigMatchCache } from './parseSettings/createParseSettings';
import { clearGlobCache } from './parseSettings/resolveProjectList';

/**
Expand All @@ -17,7 +14,6 @@ export function clearCaches(): void {
clearProgramCacheOriginal();
clearWatchCaches();
clearTSConfigMatchCache();
clearTSServerProjectService();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry for the accidental tag (meant to re-draft). Looks like CI still takes quite a while. We'll need to investigate more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

29m 5s
Run npx nx test eslint-plugin --coverage=false

> nx run eslint-plugin:test --coverage=false

 PASS  tests/rules/padding-line-between-statements.test.ts (20.724 s, 699 MB heap size)
 PASS  tests/rules/type-annotation-spacing.test.ts (16.747 s, 1151 MB heap size)
...

clearGlobCache();
}

Expand Down
4 changes: 0 additions & 4 deletions packages/typescript-estree/src/parseSettings/createParseSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,6 @@ export function clearTSConfigMatchCache(): void {
TSCONFIG_MATCH_CACHE?.clear();
}

export function clearTSServerProjectService(): void {
TSSERVER_PROJECT_SERVICE = null;
}

/**
* Ensures source code is a string.
*/
Expand Down