Skip to content

feat(utils): define SourceCode#getScope and deprecate Context#getScope #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat(utils): define SourceCode#getScope and deprecate Context#getScope #7810

wants to merge 3 commits into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 20, 2023

PR Checklist

Overview

I'm still triaging the implications of this over in eslint-plugin-jest, but for now we can at least get the types added - it's a bit annoying it was added in such a late minor and will be removed in the next immediate major but that's for us to deal with I guess 🤷

I assume updates will be needed throughout this codebase but have not actually looked - I know that unbound-method needs updating as our fork of it is omitting deprecation warnings; maybe it would be worth shipping a new util that handles falling back if needed to avoid being a breaking change 🤔

(I also can't remember if you prefer using feat, fix, or chore for type-only changes - no offense will be taken if you change the title)

References:

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 20, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bd75960
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6532d8422588b10007988df3
😎 Deploy Preview https://deploy-preview-7810--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 90 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 20, 2023

ugh I just realised we won't even be able to use this anyway as we're still stuck on v5

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 20, 2023 •
edited
Loading

cc @SimenB FYI in case you notice the warnings in eslint-plugin-jest, so you know I'm working on them :)

@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bd75960. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 20, 2023

Closing in favor of #7812

@G-Rath G-Rath closed this Oct 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@G-Rath