fix(eslint-plugin): [no-unused-vars] handle logical assignment #7854
Conversation
|
Thanks for the PR, @yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| /** | ||
| * Checks whether the given operator is a logical assignment operator or not. | ||
| * @param operator The operator |
There was a problem hiding this comment.
[Proofreading] Just nitpicking a bit: @param operator The operator gives no new information and just takes up space.
- I wrote a lint rule for this 😄 https://github.com/JoshuaKGoldberg/are-docs-informative -> https://github.com/gajus/eslint-plugin-jsdoc/blob/aefceca7413ac0263ed1b58127fff4efca89de4f/docs/rules/informative-docs.md#readme.
- Filed Repo: Bring in eslint-plugin-jsdoc recommended-typescript-error preset #7855 to lint for it automatically
| * @param operator The operator |
| * @param operator The operator | ||
| * @returns True if the operator is a logical assignment operator. | ||
| */ | ||
| function isLogicalAssignmentOperator(operator: string): boolean { |
There was a problem hiding this comment.
[Style] Just curious, is it a strong preference on your end to make this a function? I can see an advantage of it being a bit more natural to read in the isUsedVariable function, but it's a lot more lines this way.
I'm not particularly passionate about the issue, but would prefer it just be inlined (unless you have strong feelings).
There was a problem hiding this comment.
Thanks. I think the code reads well enough without the function, I'll change it.
PR Checklist
Overview