Skip to content

feat(eslint-plugin): [no-floating-promises] Add ignoreVoid option #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2019
Merged

feat(eslint-plugin): [no-floating-promises] Add ignoreVoid option #796

merged 3 commits into from
Sep 12, 2019

Conversation

phaux
Copy link
Contributor

@phaux phaux commented Aug 3, 2019 •
edited
Loading

Fixes #744

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @phaux!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Aug 3, 2019
bradzacher
bradzacher approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this!

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2019
JamesHenry
JamesHenry approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @phaux!

@JamesHenry JamesHenry removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #796 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         115      115           
  Lines        5011     5011           
  Branches     1399     1399           
=======================================
  Hits         4717     4717           
  Misses        166      166           
  Partials      128      128
Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 100% <100%> (ø) ⬆️

@JamesHenry JamesHenry merged commit 6a55921 into typescript-eslint:master Sep 12, 2019
@mightyiam mightyiam mentioned this pull request Oct 3, 2019
Closed
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
@phaux phaux deleted the no-floating-promises-ignore-void branch February 27, 2021 15:03
@phaux phaux restored the no-floating-promises-ignore-void branch February 27, 2021 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-floating-promises] Suppress no-floating-promises rule with void operator
3 participants
@phaux @JamesHenry @bradzacher