chore(website): use less text for type checked filter #7993
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Mmmm, I see that the preset is called |
| @@ -231,7 +231,7 @@ export default function RulesTable(): React.JSX.Element { | |||
| setMode={(newMode): void => | |||
| changeFilter('typeInformation', newMode) | |||
| } | |||
| label={`${TYPE_INFORMATION_EMOJI} requires type information`} | |||
| label={`${TYPE_INFORMATION_EMOJI} type checked`} | |||
There was a problem hiding this comment.
cc @Zamiell, following up on #7666 (comment) 👋
| @@ -231,7 +231,7 @@ export default function RulesTable(): React.JSX.Element { | |||
| setMode={(newMode): void => | |||
| changeFilter('typeInformation', newMode) | |||
| } | |||
| label={`${TYPE_INFORMATION_EMOJI} requires type information`} | |||
| label={`${TYPE_INFORMATION_EMOJI} type checked`} | |||
There was a problem hiding this comment.
@Josh-Cena from #7993 (review) and #7993 (review):
Is the notion of "type checked" mentioned anywhere? To me it could be interpreted as "the rule itself is type checked" and that other rules are like ESLint core rules (just JavaScript running rogue). Me playing devil's advocate though.
Mmmm, I see that the preset is called recommended-type-checked. Maybe that counts as one occasion.
Yeah I think the phrase "type checked" is a good one for us to repeat. It's pretty succinct and I can't think of anything more clear.
PR Checklist
Overview
Uses slightly smaller text for the biggest button on the page.