-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: blog post on parserOptions.projectService #8031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: blog post on parserOptions.projectService #8031
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
❌ Deploy Preview for typescript-eslint failed.
|
packages/website/blog/2023-09-18-parser-options-project-true.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see exciting features
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
packages/website/blog/2024-03-01-parser-options-project-service.md
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2cead57. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 12 targets
Sent with 💌 from NxCloud. |
Status update: this is roughly ready for review except |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8031 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 403 403
Lines 13796 13796
Branches 4022 4022
=======================================
Hits 12131 12131
Misses 1358 1358
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
We recommend switching to `parserOptions.projectService` if possible. | ||
|
||
## ⚡️ Performance Comparisons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't forget: t3-oss/create-t3-app#1936 (comment) is an example of a perf improvement in the wild.
packages/website/blog/2024-08-15-parser-options-project-service.mdx
Outdated
Show resolved
Hide resolved
Can you rebase this on main? It looks like the PR has 475 changed files, which doesn't seem to be right. (Context: I'm trying to read the upcoming blog post to learn more about how exactly to configure my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here are unintentional merge artifacts. Will revert.
- ESLint's `--fix` mode breaks type information after the first run ([#9577](https://github.com/typescript-eslint/typescript-eslint/pull/9577)) | ||
- Extra file extensions, such as those used by `.svelte` and `.vue`, are not supported ([#9504](https://github.com/typescript-eslint/typescript-eslint/issues/9504)) | ||
|
||
typescript-eslint's single-run inference enables uses common heuristics such as checking for `'--fix'` in `process.argv`, the presence of `process.env.CI`, and the presence of `parserOptions.extraFileExtensions`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo, I made a guess at the intended wording:
typescript-eslint's single-run inference enables uses common heuristics such as checking for `'--fix'` in `process.argv`, the presence of `process.env.CI`, and the presence of `parserOptions.extraFileExtensions`. | |
typescript-eslint's single-run inference uses common heuristics such as checking for `'--fix'` in `process.argv`, the presence of `process.env.CI`, and the presence of `parserOptions.extraFileExtensions`. |
PR Checklist
Overview
Adds a blog post that describes using
parserOptions.projectService
(what we currently callparserOptions.EXPERIMENTAL_useProjectService
).It sets up a plan to call itAny renaming plans are removed.projectService
in v7, then replaceproject
in v8.Note that this is blocked on:
a new, not-yet-created https://github.com/typescript-eslint/project-apis-performance-comparisonhttps://github.com/typescript-eslint/performanceThis is where my mindset is for the option.
💖