Skip to content

chore: resolve internal lint issues with new no-useless-template-literals rule #8060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023
Merged

chore: resolve internal lint issues with new no-useless-template-literals rule #8060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rule-schema-to-typescript-types/src/printAST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function printAndMaybeParenthesise(ast: AST): CodeWithComments {
};
}
return {
code: `${printed.code}`,
code: printed.code,
commentLines: printed.commentLines,
};
}
2 changes: 1 addition & 1 deletion packages/scope-manager/tests/util/serializers/TSESTreeNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const serializer: NewPlugin = {

const keys = Object.keys(node).filter(k => !EXCLUDED_KEYS.has(k));
if (keys.length === 0) {
return `${node.type}`;
return node.type;
}

if (SEEN_NODES.has(node)) {
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/tests/util/serializers/baseSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function createSerializer<TConstructor extends ConstructorSignature>(

if (thing.$id) {
if (SEEN_THINGS.has(thing)) {
return `${name}`;
return name;
}
SEEN_THINGS.add(thing);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/website/src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function Feature({ title, description }: FeatureItem): React.JSX.Element {
function Home(): React.JSX.Element {
const { siteConfig } = useDocusaurusContext();
return (
<Layout description={`${siteConfig.tagline}`}>
<Layout description={siteConfig.tagline}>
<main>
<div className={clsx('hero hero--dark', styles.hero)}>
<div className="container">
Expand Down