Skip to content

docs(eslint-plugin): [require-array-sort-compare] generalize sort method names #8062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

docs(eslint-plugin): [require-array-sort-compare] generalize sort method names #8062

merged 1 commit into from
Dec 13, 2023

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Dec 13, 2023

PR Checklist

Overview

This is a follow-up to my previous PR to make the docs more consistent, since there are two sort methods now.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 09c4702
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6579bdb1dac52a00082a91b6
😎 Deploy Preview https://deploy-preview-8062--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: streamline docs(eslint-plugin): [require-array-sort-compare] generalize sort method names Dec 13, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm realizing now I missed a few things with the last round of PR reviews on this rule 😅 thanks for catching them.

Quick notice to please use the repo's general format for PR titles. It helps with auto-generation of changelogs and general repo management (e.g. GH search queries).

@JoshuaKGoldberg JoshuaKGoldberg merged commit f5e712b into typescript-eslint:main Dec 13, 2023
@Zamiell Zamiell deleted the lint-fix branch December 13, 2023 17:16
c0sta pushed a commit to c0sta/typescript-eslint that referenced this pull request Dec 18, 2023
@Zamiell @c0sta
docs(eslint-plugin): [require-array-sort-compare] generalize sort met…
47390bb 
…hod names (typescript-eslint#8062)

docs: streamline
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zamiell @JoshuaKGoldberg