Skip to content

docs(eslint-plugin): [prefer-readonly-parameter-types] fix broken code samples #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

auvred
Copy link
Member

@auvred auvred commented Dec 26, 2023

PR Checklist

Overview

n/a

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 886e147
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/658abf1bf9d16300087eac07
😎 Deploy Preview https://deploy-preview-8135--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit cde4d4d into typescript-eslint:main Dec 26, 2023
auvred added a commit to auvred/typescript-eslint that referenced this pull request Dec 29, 2023
…e samples (typescript-eslint#8135)

* docs(eslint-plugin): [prefer-readonly-parameter-types] fix broken code samples
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: prefer-readonly-parameter-types rule docs contains broken examples
2 participants