test(eslint-plugin): assert that ts/tsx code blocks in docs are syntactically valid
#8142
Conversation
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| const Comp: FC = () => { | ||
| return <button onClick={() => {}} />; | ||
| }; |
There was a problem hiding this comment.
We can't mix angle bracket assertions and jsx syntax
packages/eslint-plugin/docs/rules/consistent-type-assertions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
LGTM, thanks!
I know @Josh-Cena has done a lot with Docusaurus things so leaving open in case they have a chance to review. Will come and merge back in a week otherwise.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
| }, | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| range: true, |
There was a problem hiding this comment.
Without range: true parser throws Cannot read properties of undefined (reading '0') on valid code
…yntactically valid (typescript-eslint#8142) * test(eslint-plugin): assert that `ts`/`tsx` code blocks in docs are syntactically valid * revert unintended changes in space-before-blocks.md * chore: shorten examples in consistent-type-assertions.md * refactor: do not parse md file again * docs: more consistent examples for consistent-type-assertions * docs: convert `js` code blocks to `ts` * Update packages/eslint-plugin/tests/docs.test.ts Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> * chore: use regex instead of startsWith * chore: fix few codesamples --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
PR Checklist
Overview
For now, just trying to parse each code block with
tsandtsxlang