Skip to content

chore(typescript-estree): fix lint / CI #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore(typescript-estree): fix lint / CI #8188

merged 2 commits into from
Jan 4, 2024

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Jan 4, 2024 •
edited
Loading

Fixes: #8164

this just fixes CI on main, looks like it has been broken for several weeks?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit abb2293
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6596d70354e3940009c2dc8b
😎 Deploy Preview https://deploy-preview-8188--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zamiell Zamiell changed the title chore: fix lint / CI chore(typescript-estree): fix lint / CI Jan 4, 2024
@auvred
Copy link
Member

auvred commented Jan 4, 2024

fixes #8164

@Zamiell
Copy link
Contributor Author

Zamiell commented Jan 4, 2024

thanks, I edited that into the OP

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is the right fix. The nodes were previously being considered duplicate type constituents because they used to be type aliases. But then TypeScript changed them to interfaces so they can be merged: microsoft/TypeScript#56477

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 53f4c37 into typescript-eslint:main Jan 4, 2024
@Zamiell Zamiell deleted the fix-lint branch January 4, 2024 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: lint fails on main branch after updating typescript to 5.3.3
3 participants
@Zamiell @auvred @JoshuaKGoldberg