Skip to content

docs: add import/no-unresolved to perf troubleshooting docs #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 28, 2024
Merged

docs: add import/no-unresolved to perf troubleshooting docs #8190

merged 7 commits into from
Jan 28, 2024

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Jan 4, 2024

PR Checklist

Overview

I added 2 rules to the page, which are the following:

  • import/no-unresolved
  • import/unambiguous

I believe that these are correctly handled by the TypeScript compiler, correct me if I am wrong.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6bd2063
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65a28e97ebad3600081ec696
😎 Deploy Preview https://deploy-preview-8190--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending! I don't think any of these changes need to land, but maybe I'm wrong?

Also: please always write an unambiguous title for PRs. That helps both reviewers understand quickly what's going on, and helps the changelog be more informative.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jan 11, 2024
@bradzacher bradzacher changed the title docs: update Performance.mdx docs: add import/no-unresolved to perf troubleshooting docs Jan 28, 2024
@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating awaiting response Issues waiting for a reply from the OP or another party and removed awaiting response Issues waiting for a reply from the OP or another party labels Jan 28, 2024
@bradzacher bradzacher merged commit a9f995a into typescript-eslint:main Jan 28, 2024
@Zamiell Zamiell deleted the patch-1 branch January 28, 2024 02:09
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants