chore: the big package renaming #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
suggested changes
Jan 19, 2019
| @@ -40,7 +40,7 @@ ruleTester.run('tslint/config', rules.config, { | |||
| valid: [ | |||
| { | |||
| code: 'var foo = true;', | |||
| parser: 'typescript-eslint-parser', | |||
| parser: '@typescript-eslint/parser', | |||
There was a problem hiding this comment.
can you move parser and parserOptions to
const ruleTester = new RuleTester();const ruleTester = new RuleTester({
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
ecmaFeatures: {}
},
parser: '@typescript-eslint/parser',
project: './tests/tsconfig.json'
});| // their work around exposing the parser. They may require that there be a project config field in | ||
| // the eslint config, in which case we should check and/or report that here appropriately. | ||
| throw new Error( | ||
| 'This rule requires you to use `eslint-plugin-typescript/parser`.' | ||
| 'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.' |
There was a problem hiding this comment.
Suggested change
| 'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.' | |
| `You must provide a value for the "parserOptions.project" property for @typescript-eslint/parser` |
its same message as in plugin-tslint
|
@armano2 Thanks I've noted down your points, adding them to my follow up PR - lots of tweaks to make yet anyway and I don't want anyone starting any WIP without the big reorg/renaming |
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate everything under their new scoped names, yes this is unreviewable, but fortunately it is a one-off! :)
Better docs will follow after this before 1.0.0 tomorrow