Skip to content

chore(website): bump Docusaurus to v3 #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 17, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 7, 2024

PR Checklist

Overview

  • Bumping relevant packages to latest versions
  • yarn start starting the local dev server
  • Tabs plugin: switched to manual <Tabs> & <TabsItem>s
  • TypeScript config
  • No TypeScript type checking errors
  • No ESLint linting errors
  • No Markdownlint linting errors
  • Stricter parsing of generated .md files
  • Passing Docusaurus build
  • No Docusaurus build lint complaints (except linking to /play#...)
  • Custom MDX components in internal plugins
  • Investigate any new warnings

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f749c17
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f7040596de7000081a1cc9
😎 Deploy Preview https://deploy-preview-8209--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@auvred auvred mentioned this pull request Jan 8, 2024
26 tasks
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party package: website Issues related to the @typescript-eslint website labels Feb 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested review from Josh-Cena and removed request for Josh-Cena February 21, 2024 19:46
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 21, 2024 19:46
@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 21, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base (ce79c55) to head (947d034).
Report is 1 commits behind head on main.

❗ Current head 947d034 differs from pull request most recent head f749c17. Consider uploading reports for the commit f749c17 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8209      +/-   ##
==========================================
+ Coverage   87.23%   87.74%   +0.51%     
==========================================
  Files         251      398     +147     
  Lines       12334    13827    +1493     
  Branches     3881     4067     +186     
==========================================
+ Hits        10760    12133    +1373     
- Misses       1305     1397      +92     
- Partials      269      297      +28     
Flag Coverage Δ
unittest 87.74% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 230 files with indirect coverage changes

bradzacher
bradzacher previously approved these changes Mar 16, 2024
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly clicking around it looks like things are (at least mostly) working - so I'm happy for you to merge this whenever you get CI passing!
I trust you to do the last of the work to get this finished :)
Worst case we can always follow up with some patches if we miss something.

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 16, 2024
@JoshuaKGoldberg
Copy link
Member Author

ast-spec's test failures aren't related to this branch. This PR doesn't touch packages/ast-spec, packages/typescript-estree, packages/utils, or non-md(x)/*.test.* files in packages/eslint-plugin.

 $ git diff main | grep "diff --git" | grep -v ".tsx" | grep -v ".md" | grep -v "packages/website"
diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.ts
diff --git a/packages/repo-tools/src/generate-contributors.mts b/packages/repo-tools/src/generate-contributors.mts
diff --git a/yarn.lock b/yarn.lock

Merging so I don't have to keep dealing with merge failures. If there's a snapshot failure on main afterwards I'll take a look. 🤘

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8640908 into typescript-eslint:main Mar 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the docusaurus-3 branch March 17, 2024 15:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge package: website Issues related to the @typescript-eslint website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Bump to Docusaurus v3
4 participants