Skip to content

chore: fix test formatting in prefer-readonly.test.ts #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 8, 2024

PR Checklist

Overview

Manually formats the failing snippets.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7868680
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/659c3a7c76731b0008435553
😎 Deploy Preview https://deploy-preview-8223--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member Author

😬 surely we're not still being throttled from the accessibility-alt-text-bot thing...

Screenshot of six workflows queued, from as long ago as 30 minutes

@JoshuaKGoldberg
Copy link
Member Author

Well I ran this yarn lint and yarn test locally. All is well. I'll just merge now to get the release going.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 78db0ad into typescript-eslint:main Jan 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-readonly-test-formatting branch January 8, 2024 18:46
@JoshuaKGoldberg
Copy link
Member Author

Oh, dangit, this fixed #8222. Not #8220.

Things are not going well for me today 🙃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: release script breaks on call to yargs.version(false)
1 participant