docs: underline URLs, change contrast in syntax highlighting #8225
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,16 +6,16 @@ | |
| --token-color-doctype: #008000; | ||
| --token-color-string: #a31515; | ||
| --token-color-operator: #393a34; | ||
| --token-color-symbol: #277c7b; | ||
| --token-color-number: #098658; | ||
| --token-color-keyword: #00f; | ||
| --token-color-function: #2b74b1; | ||
| --token-color-function-variable: #000; | ||
| --token-color-important: #e90; | ||
| --token-color-class-name: #237690; | ||
| --token-color-selector: #800000; | ||
| --token-color-regexp: #800000; | ||
| --token-color-property: #c70000; | ||
|
Comment on lines
+9
to
+18
There was a problem hiding this comment. [Curious] How did you choose those specific colors? There was a problem hiding this comment. I ran axe devtools to see which colors on each page were below the 4.5:1 threshold and then I used this website to check the contrast ratio and modify the current foreground color until it was over that amount. Then I re-ran the devtools to verify the changes were adequate 🙂. There was a problem hiding this comment. Big +1 on https://webaim.org/resources/contrastchecker, great tool! |
||
| --token-color-builtin: #00f; | ||
| --token-color-boolean: #00f; | ||
| --token-color-inserted: #247e81; | ||
|
|
@@ -28,9 +28,9 @@ html[data-theme='dark'] { | |
| --token-color: #f8f8f2; | ||
| --token-background: var(--ifm-background-surface-color); | ||
| --token-border: #414458; | ||
| --token-color-comment: #9e9e9e; | ||
| --token-color-doctype: #6a9955; | ||
| --token-color-string: #78a861; | ||
| --token-color-operator: #d4d4d4; | ||
| --token-color-symbol: #b5cea8; | ||
| --token-color-number: #b5cea8; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[tip] Try to avoid fixing several unrelated issues in one PR, even if they are small. This is generally a good practice + it helps maintainers better focus on reviewing fixes for a particular issue.
If two issues are about the same bug/feature, then they should be merged into one issue. Thus, one issue = one PR